[Mesa-dev] [PATCH 4/7] glsl: Request an Nx1 type instance in ir_quadop_vector lowering pass.

[Kenneth Graunke]

On 07/27/2012 11:20 AM, Olivier Galibert wrote:
> On Fri, Jul 27, 2012 at 10:49:22AM -0700, Kenneth Graunke wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> No types have 0 columns.  The glsl_type::get_instance method contains
>>
>>    if ((rows < 1) || (rows > 4) || (columns < 1) || (columns > 4))
>>       return error_type;
>>
>> To get a vector, use columns = 1.
> 
> Reviewed-by: Olivier Galibert <galibert at pobox.com>
> 
> That's an obvious bugfix.  If there's a stable branch with the glsl
> compiler in, it probably should go there.
> 
>   OG.

Ian originally had it marked as a candidate for stable branches, but
nobody actually uses ir_quadop_vector in any release.  We could pick it
over, but it shouldn't affect anything either way.