[Mesa-dev] [PATCH 7/7] ir_to_mesa: Don't set component for ir_dereference in ir_quadop_vector

Olivier Galibert galibert at pobox.com
Fri Jul 27 12:00:10 PDT 2012

On Fri, Jul 27, 2012 at 10:49:25AM -0700, Kenneth Graunke wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> There can only be one variable used in an ir_quadop_vector.  Accesses
> of this variable must be swizzled.

There's nothing anywhere ensuring the presence of the swizzle.  I
completely agree that trashing the components value is a bad idea, but
you should have SWIZZLE_X as a default value for the components array.

Amusingly enough, it's already the case (SWIZZLE_X==0), so making it
explicit would be perfect.


More information about the mesa-dev mailing list