[Mesa-dev] [PATCH] i965: enable ARB_instanced_arrays extension

Eric Anholt eric at anholt.net
Mon Jun 4 22:31:36 CEST 2012


On Sun, 27 May 2012 21:08:07 -0700, Jordan Justen <jordan.l.justen at intel.com> wrote:
> Set the step_rate value when drawing to implement
> ARB_instanced_arrays for gen >= 4.

> @@ -504,7 +513,7 @@ static void brw_prepare_vertices(struct brw_context *brw)
>  
>  	 nr_uploads = 0;
>        }
> -      else if (total_size < 2048) {
> +      else if (can_merge_uploads) {
>  	 /* Upload non-interleaved arrays into a single interleaved array */
>  	 struct brw_vertex_buffer *buffer;
>  	 int count = MAX2(max_index - min_index + 1, 1);

The total_size < 2048 check probably should stay down here rather than
get moved inside the loop up above.  Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120604/88978e6b/attachment.pgp>


More information about the mesa-dev mailing list