[Mesa-dev] [PATCH] i915g: Fix depth/stencil glClear

Daniel Vetter daniel at ffwll.ch
Sun Jun 10 07:35:00 PDT 2012


On Sun, Jun 10, 2012 at 01:20:36PM +0200, Daniel Vetter wrote:
> On Sun, Jun 10, 2012 at 01:49:30AM +0200, Michael Karcher wrote:
> > This patch fixes a copy/paste error and masking of depth/stencil (stencil
> > is in the top 8 bits), and makes glean/readPixSanity happy.
> > 
> > Both the stencil and the depth buffer piglit test also pass if
> > glClear(DEPTH | STENCIL) is executed instead of
> > glClear(DEPTH)/glClear(STENCIL).
> 
> Woot, nice catch - iirc this problem elluded me for about a year, i.e.
> since I've enabled hw clears.
> 
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Do you have commit access or should I do that?

This fixes Christopher's long-standing issue with hw clears with portal,
so I've gone right ahead and commited it. Thanks a lot for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the mesa-dev mailing list