[Mesa-dev] [PATCH 06/21] mesa: Move DepthMode to texture object

[Eric Anholt]

On Mon, 11 Jun 2012 09:59:21 +0300, Pauli Nieminen <pauli.nieminen at linux.intel.com> wrote:
> GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on
> compatibility profile specifications.
> 
> OpenGL specification 4.1 compatibility 20100725 3.9.2:
> "... The values accepted in the pname parameter
> are TEXTURE_WRAP_S, TEXTURE_WRAP_T, TEXTURE_WRAP_R, TEXTURE_MIN_-
> FILTER, TEXTURE_MAG_FILTER, TEXTURE_BORDER_COLOR, TEXTURE_MIN_-
> LOD, TEXTURE_MAX_LOD, TEXTURE_LOD_BIAS, TEXTURE_COMPARE_MODE, and
> TEXTURE_COMPARE_FUNC. Texture state listed in table 6.25 but not listed here and
> in the sampler state in table 6.26 is not part of the sampler state, and remains in the
> texture object."
> 
> Same can be found from 3.3 compatibility specification.
> 
> That makes me think that moving DepthMode from sampler state makes sense
> to avoid bugs if DepthMode happens to be used with sampler objects.

Specifically, it's in "Table 6.24. Textures (state per texture object)",
so that seems pretty clear.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120611/706c2269/attachment-0001.pgp>