[Mesa-dev] [PATCH 01/19] automake: Don't warn on gmake portability issues.

Dan Nicholson dbn.lists at gmail.com
Wed Jun 13 10:45:02 PDT 2012


On 6/13/12, Eric Anholt <eric at anholt.net> wrote:
> Even pre-automake, we rely on gmake features for pattern
> substitutions, and replacing those with reams more make code is not
> interesting.  This will let us turn the old Makefiles using pattern
> substitutions into automake without spewing warnings.
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 29ee87b..19c5111 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,7 +10,7 @@ AC_INIT([Mesa], [8.1.0],
>      [https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa])
>  AC_CONFIG_AUX_DIR([bin])
>  AC_CANONICAL_HOST
> -AM_INIT_AUTOMAKE([foreign -Wall])
> +AM_INIT_AUTOMAKE([foreign])
>
>  dnl http://people.gnome.org/~walters/docs/build-api.txt
>  dnl We don't support srcdir != builddir.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

Like I was saying yesterday, if there are other useful warnings in
-Wall, you can specifically turn off the gmake warning by adding
-Wno-portability. I think this is fine, though.

--
Dan


More information about the mesa-dev mailing list