[Mesa-dev] [PATCH] st/mesa: make unsupported renderbuffer formats always fail as FBO incomplete

[Brian Paul]

On Fri, Jun 15, 2012 at 8:23 AM, Marek Olšák <maraeo at gmail.com> wrote:
> On Fri, Jun 15, 2012 at 4:07 PM, Brian Paul <brian.e.paul at gmail.com> wrote:
>>
>> I don't think this last bit of code will be reached for non-texture
>> attachments (which are allocated with RenderbufferStorage()).  At the
>> beginning of st_validate_attachment() we check if the attachment type
>> is not a texture and return.  I guess we could remove that check, but
>> then we need to get rid of stObj and get the attachment's format from
>> st_renderbuffer::texture->format, etc.
>
> I see. I've got a better idea how to deal with this. I'll send a new
> patch later.
>
>>
>> Just curious: have you tried NVIDIA's or AMD's driver to see what
>> happens when you try to allocate an unsupported renderbuffer format?
>
> Yes, and you too. :)
>
> NVIDIA and multiple formats:
> http://lists.freedesktop.org/archives/mesa-dev/2012-May/021994.html
>
> AMD and RGB9_E5:
> http://lists.freedesktop.org/archives/mesa-dev/2012-May/021918.html

Right.  I guess I was thinking of the multisample case.  I'm thinking
there's some pixel formats that don't work with multisampling and
wondering if things behave any differently.

-Brian