[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #6 from Török Edwin <edwin+mesa at etorok.net> 2012-06-18 10:28:38 PDT ---
(In reply to comment #4)
> 
> R700 chips normalize trigonometric inputs the same was as Evergreen+, so the
> correct fix would be to create a SIN_r700 instruction and use the TRIG_eg class
> to create a pattern for it.

Thanks, the attached patch seems to fix the problem for me.

>  This will also require adding a predicate to
> identify r700 chips, because r600 normalizes the inputs differently.

Oldest chip listed is OCL_DEVICE_RV710, so it would appear that R600_LLVM
only supports chips >= RV710 and doesn't support R600 at all. Am I missing
something?
Anyway the patch checks for HD4XXX and >= RV710.

(In reply to comment #5)
> Created attachment 63183 [details] [review]
> SIN/COS_r700 as suggested

This patch makes HoN stop crashing, but it'll actually fall back to using TGSI
(due to indirect addressing) so I don't know if the rendering would be correct.
Piglit tests about sin/cos pass though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.