[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #8 from Tom Stellard <tstellar at gmail.com> 2012-06-18 10:57:31 PDT ---
Comment on attachment 63183
  --> https://bugs.freedesktop.org/attachment.cgi?id=63183
SIN/COS_r700 as suggested

> 
>@@ -809,13 +812,21 @@ def RECIP_UINT_eg : RECIP_UINT_Common<0x94>;
> /* Evergreen / Cayman Instructions */
> /* ------------------------------- */
> 
>-let Predicates = [isEGorCayman] in {
>-  
> class TRIG_eg <InstR600 trig, Intrinsic intr> : Pat<
>   (intr R600_Reg32:$src),
>   (trig (MUL (MOV_IMM_I32 (i32 ALU_LITERAL_X), CONST.TWO_PI_INV), R600_Reg32:$src))
> >;
> 
>+let Predicates = [isR700] in {
>+  /* R700 normalizes inputs to SIN/COS the same as EG */
>+  def SIN_r700 : SIN_Common<0x6E>;
>+  def COS_r700 : COS_Common<0x6F>;
>+
>+  def : TRIG_eg <SIN_r700, int_AMDGPU_sin>;
>+  def : TRIG_eg <COS_r700, int_AMDGPU_cos>;
>+}

Can you move these R700 instruction definitions above the Evergreen Only
instructions, so the chip definitions are in chronological order.  There should
also be an 'R700 Only Instructions' header comment similar to the 'Evergreen
Only' header.

Could you also delete the TRIG_HELPER_r700 class as well as the header comment
above it now that it is no longer needed.

Otherwise looks good. If possible, use git-format-patch when you repost.  It
will make it easier for me to commit and push.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.