[Mesa-dev] [PATCH] i965: Fix brw_swap_cmod() for LE/GE comparisons.

Eric Anholt eric at anholt.net
Mon Jun 18 15:15:28 PDT 2012


On Sat, 16 Jun 2012 02:20:09 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want
> to simply exchange arguments, not negate the condition.  If equality was
> part of the original comparison, it should remain part of the swapped
> version.
> 
> This is the true cause of bug #50298.  It didn't manifest itself on
> Sandybridge because we embed the conditional modifier in the IF
> instruction rather than emitting a CMP.  All other platforms use CMP.

*headdesk*

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120618/131a0d01/attachment.pgp>


More information about the mesa-dev mailing list