[Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

[Jose Fonseca]

----- Original Message -----
> On 06/19/2012 11:34 PM, Vinson Lee wrote:
> > The GLX headers on Solaris are not recent enough.
> > 
> > Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> > ---
> >  src/SConscript |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/src/SConscript b/src/SConscript
> > index 75c4446..f55a20e 100644
> > --- a/src/SConscript
> > +++ b/src/SConscript
> > @@ -23,7 +23,7 @@ SConscript('mesa/SConscript')
> >  SConscript('mapi/vgapi/SConscript')
> >  
> >  if not env['embedded']:
> > -    if env['platform'] not in ('cygwin', 'darwin', 'freebsd',
> > 'haiku', 'windows'):
> > +    if env['platform'] not in ('cygwin', 'darwin', 'freebsd',
> > 'haiku', 'sunos', 'windows'):
> >          SConscript('glx/SConscript')
> >      if env['platform'] not in ['darwin', 'haiku', 'sunos']:
> >          SConscript('egl/main/SConscript')
> 
> It doesn't sound very useful to build Mesa on Solaris without GLX
> support.  I guess you could use EGL, but...most existing apps use
> GLX,
> so I imagine not much would run...
> 
> That said, I don't use Solaris nor SCons, so it's not really my place
> to
> say...

I agree. I don't know what's the end goal of Solaris support, but I can't see much use to build on Solaris without GLX.

Mesa already ships some glx headers, so maybe a better solution would be to ensure that they are included before system headers on scons.

Jose