[Mesa-dev] [PATCH] llvmpipe: Remove the ARB_draw_instanced capability.

Christoph Bumiller e0425955 at student.tuwien.ac.at
Mon Jun 25 04:21:45 PDT 2012


On 25.06.2012 08:37, Olivier Galibert wrote:
> That capability requires integer handling and that's not yet active,
> ending with a failure in draw-non-instanced unless you force it on.
> See bug 51366.
>     
> Frankly, I'd rather have that patch rejected and integer/glsl 130
> capability activated instead.  There still are things missing, but
> they mostly have their own extension anyway.  And the overall picture
> ain't so bad.
>     
> Signed-off-by: Olivier Galibert <galibert at pobox.com>
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 40037a5..5eb826e 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -152,8 +152,6 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>        return 1;
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>        return 0;
> -   case PIPE_CAP_TGSI_INSTANCEID:
> -   case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:

With VERTEX_ELEMENT_INSTANCE_DIVISOR you'd be removing
GL_ARB_instanced_arrays, which doesn't need integers.

>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>     case PIPE_CAP_CONDITIONAL_RENDER:
>        return 1;
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list