[Mesa-dev] [PATCH] [RFC] r600g: improve flushed depth texture allocation

[Andreas Boll]

2012/6/25 Vadim Girlin <vadimgirlin at gmail.com>:
> On Mon, 2012-06-25 at 12:19 +0200, Andreas Boll wrote:
>> 2012/6/24 Vadim Girlin <vadimgirlin at gmail.com>:
>> > On Sun, 2012-06-24 at 17:43 +0400, Vadim Girlin wrote:
>> >> Allocate flushed depth texture in the VRAM if we aren't going to access it by
>> >> CPU. If we need CPU access later, then it'll be reallocated in the GTT.
>> >> Currently it's not reallocated in the opposite direction (GTT->VRAM), though
>> >> probably we might want to do it too. Anyway, it helps the apps that don't need
>> >> to access flushed depth texture by CPU at all, e.g. Lightsmark.
>> >>
>> >> Improves performance for Lightsmark.
>> >>
>> >> Signed-off-by: Vadim Girlin <vadimgirlin at gmail.com>
>> >> ---
>> >
>> > You can also find this patch and some other patches that aren't
>> > committed yet (shader caching, dual export) in the r600-perf branch in
>> > my github mesa repo:
>> >
>> > git://github.com/VadimGirlin/mesa.git
>> >
>> > www: https://github.com/VadimGirlin/mesa/compare/r600-perf
>> >
>> > Could anybody test them for regressions on non-evergreen cards
>> > (R6xx/7xx/CAYMAN)?
>> >
>> > Vadim
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>> following piglit tests regresses on my rv770:
>>
>
> Thanks. I've updated the branch with a possible fix, could you test it
> again?
>
> Vadim
>
>> ./piglit-run.py --tests=fbo-draw-buffers-blend
>> --tests=fbo-drawbuffers-arbfp --tests=fbo-drawbuffers2-*
>> --tests=fbo-drawbuffers-blend-add --tests=fbo-drawbuffers-maxtarget
>> --tests=mixed-mrt --tests=arb_draw_buffers-state_change
>> --tests=arbfp-no-index --tests=ati_draw_buffers-arbfp
>> tests/quick.tests results/regression
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-drawbuffers-arbfp
>> [Mon Jun 25 12:03:52 2012] ::     fail :: fbo/fbo-drawbuffers-arbfp
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-drawbuffers2-colormask
>> [Mon Jun 25 12:03:52 2012] ::     fail :: fbo/fbo-drawbuffers2-colormask
>> [Mon Jun 25 12:03:52 2012] ::  running :: spec/ARB_color_buffer_float/mixed-mrt
>> [Mon Jun 25 12:03:52 2012] ::     fail :: spec/ARB_color_buffer_float/mixed-mrt
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-draw-buffers-blend
>> [Mon Jun 25 12:03:52 2012] ::     fail :: fbo/fbo-draw-buffers-blend
>> [Mon Jun 25 12:03:52 2012] ::  running :: spec/ATI_draw_buffers/arbfp-no-index
>> [Mon Jun 25 12:03:52 2012] ::     fail :: spec/ATI_draw_buffers/arbfp-no-index
>> [Mon Jun 25 12:03:52 2012] ::  running ::
>> spec/ATI_draw_buffers/ati_draw_buffers-arbfp
>> [Mon Jun 25 12:03:52 2012] ::     fail ::
>> spec/ATI_draw_buffers/ati_draw_buffers-arbfp
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-drawbuffers2-blend
>> [Mon Jun 25 12:03:52 2012] ::     fail :: fbo/fbo-drawbuffers2-blend
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-drawbuffers-blend-add
>> [Mon Jun 25 12:03:52 2012] ::     fail :: fbo/fbo-drawbuffers-blend-add
>> [Mon Jun 25 12:03:52 2012] ::  running :: fbo/fbo-drawbuffers-maxtargets
>> [Mon Jun 25 12:03:53 2012] ::     fail :: fbo/fbo-drawbuffers-maxtargets
>> [Mon Jun 25 12:03:53 2012] ::  running ::
>> spec/ARB_draw_buffers/arb_draw_buffers-state_change
>> [Mon Jun 25 12:03:53 2012] ::     fail ::
>> spec/ARB_draw_buffers/arb_draw_buffers-state_change
>>
>> the regressions are introduced with the first commit of your branch:
>>
>> r600g: avoid unnecessary shader exports
>
>

With the updated branch I have 4 remaining regressions on my rv770:

./piglit-run.py --tests=fbo-drawbuffers-arbfp
--tests=fbo-drawbuffers-blend-add --tests=arbfp-no-index
--tests=ati_draw_buffers-arbfp tests/quick.tests results/regression
[Mon Jun 25 17:29:14 2012] ::  running :: fbo/fbo-drawbuffers-arbfp
[Mon Jun 25 17:29:14 2012] ::     fail :: fbo/fbo-drawbuffers-arbfp
[Mon Jun 25 17:29:14 2012] ::  running ::
spec/ATI_draw_buffers/ati_draw_buffers-arbfp
[Mon Jun 25 17:29:14 2012] ::     fail ::
spec/ATI_draw_buffers/ati_draw_buffers-arbfp
[Mon Jun 25 17:29:14 2012] ::  running :: spec/ATI_draw_buffers/arbfp-no-index
[Mon Jun 25 17:29:14 2012] ::     fail :: spec/ATI_draw_buffers/arbfp-no-index
[Mon Jun 25 17:29:14 2012] ::  running :: fbo/fbo-drawbuffers-blend-add
[Mon Jun 25 17:29:14 2012] ::     fail :: fbo/fbo-drawbuffers-blend-add