[Mesa-dev] [PATCH 01/13] mesa formats: add integer type/format detection routines

Brian Paul brianp at vmware.com
Tue Jun 26 14:34:14 PDT 2012


On 06/25/2012 06:34 PM, Jordan Justen wrote:
> _mesa_is_integer_format is moved to formats.c and renamed
> as _mesa_is_enum_format_integer.
>
> _mesa_is_format_unsigned, _mesa_is_type_integer,
> _mesa_is_type_unsigned, and _mesa_is_enum_format_or_type_integer
> are added.
>
> Signed-off-by: Jordan Justen<jordan.l.justen at intel.com>
> ---
>   src/mesa/main/drawpix.c                   |    2 +-
>   src/mesa/main/formats.c                   |  149 +++++++++++++++++++++++++++++
>   src/mesa/main/formats.h                   |   14 +++
>   src/mesa/main/image.c                     |   76 ---------------
>   src/mesa/main/image.h                     |    3 -
>   src/mesa/main/pack.c                      |    8 +-
>   src/mesa/main/readpix.c                   |    6 +-
>   src/mesa/main/teximage.c                  |   10 +-
>   src/mesa/state_tracker/st_cb_drawpixels.c |    2 +-
>   9 files changed, 177 insertions(+), 93 deletions(-)
[...]

So far, the formats.[ch] files only have functions which pertain to 
the gl_format type, not GLenum formats/types.  The later have been in 
image.[ch] so far.

If you'd like to refactor things a bit and move the 
format/type-related functions out of image.c to a new file (maybe 
glformats.c) that would probably be OK.

-Brian


More information about the mesa-dev mailing list