[Mesa-dev] [PATCH] glsl: be more careful about counting varying vars in the linker

[Eric Anholt]

Brian Paul <brianp at vmware.com> writes:

> Previously, we were counting gl_FrontFacing, gl_FragCoord and gl_PointCoord
> against the limit of varying variables.  This prevented some valid shaders
> from linking.
>
> The other potential solution to this is to have the driver advertise
> more varying vars or set the GLSLSkipStrictMaxVaryingLimitCheck flag.
> But the above-mentioned variables aren't conventional varying attributes
> so it doesn't seem right to count them.

These variables are so awkward.

i915 needs to pass all three as varyings.

gen4/5 needs to pass pntc as varyings.  But I think it has the space to
store it (we under-report max varyings compared to what hw can do), so
we should just make it work.

Regardless, I think this is a sensible change.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120627/55ff12b5/attachment.pgp>