[Mesa-dev] [PATCH 2/2] i915: fix wrong rendering of gl_PointSize on Pineview

[Eric Anholt]

On Fri, 2 Mar 2012 10:14:05 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> On Thu, Mar 01, 2012 at 09:54:46AM -0800, Eric Anholt wrote:
> > On Thu, 23 Feb 2012 14:19:19 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > >  
> > > +   /* Handle gl_PointSize builtin var here */
> > > +   if (ctx->Point._Attenuated || ctx->VertexProgram.PointSizeEnabled)
> > > +      EMIT_ATTR(_TNL_ATTRIB_POINTSIZE, EMIT_1F, S4_VFMT_POINT_WIDTH, 1);
> > 
> > All the other EMIT_ATTRs specify the number of bytes as the last arg.
> > It seems like this code shouldn't have worked.
> 
> Actually, it does work ;)
> 
> Well, if the last arg specify the size in _bytes_, then this patch was
> wrong. 
> 
> And here is the updated one:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120302/9351f613/attachment.pgp>