[Mesa-dev] [PATCH] i965: handle gl_PointCoord for Gen4 and Gen5 platforms

[Yuanhan Liu]

On Tue, Mar 06, 2012 at 08:25:10AM -0800, Eric Anholt wrote:
> On Mon, 27 Feb 2012 15:46:32 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > diff --git a/src/mesa/drivers/dri/i965/brw_sf.c b/src/mesa/drivers/dri/i965/brw_sf.c
> > index 6e63583..7950c47 100644
> > --- a/src/mesa/drivers/dri/i965/brw_sf.c
> > +++ b/src/mesa/drivers/dri/i965/brw_sf.c
> > @@ -125,6 +135,7 @@ brw_upload_sf_prog(struct brw_context *brw)
> >  {
> >     struct gl_context *ctx = &brw->intel.ctx;
> >     struct brw_sf_prog_key key;
> 
> There should be a /* _NEW_BUFFERS */ comment here to note the state flag
> dependency.

Ok.

> 
> > +   bool render_to_fbo = ctx->DrawBuffer->Name != 0;
> 
> Other than that,
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>

Thanks for the Reviewed-by, which I have been waiting for a quite while ;) 

Thanks,
Yuanhan Liu