[Mesa-dev] [PATCH 12/15] gallium: Add winsys loader for device enumeration and driver multiplexing.

[Jakob Bornecrantz]

----- Original Message -----
> Jakob Bornecrantz <jakob at vmware.com> writes:
> 
> >> +libws_loader_la_LIBADD = \
> >> +	$(top_srcdir)/src/gallium/winsys/sw/null/libws_null.la
> >> +
> >> +if HAVE_XLIB_LOADER_GALLIUM
> >> +libws_loader_la_LIBADD += \
> >> +	$(top_srcdir)/src/gallium/winsys/sw/xlib/libws_xlib.la
> >> +AM_CFLAGS += -DHAVE_WS_LOADER_XLIB
> >> +endif
> >
> > Ah so this explains the not sorting winsys dir, this shouldn't
> > be done on the winsys this is for the target to keep track of.
> > Just as it is the targets job to link libdrm.
> >
> 
> I had the feeling that letting a winsys link to another wouldn't be
> much of a problem, especially if all the winsys build system is
> going to be converted to automake and we're going to get a more
> automated dependency tracking.  But, if we don't want to relax
> that restriction anyway, the other possibility would be to define
> a GALLIUM_WS_LOADER_LIBS variable at configure time containing all
> the objects a target has to pull in order to link to the winsys
> loader.  Would that be OK with you?

Sounds good with me. Under the scons build we usually put that
calculation in the targets [1][2], but I guess for automake we
want a more centralized approach.

Cheers, Jakob.

[1] src/gallium/targets/egl-static/SConscript
[2] src/gallium/targets/dri-vmwgfx/SConscript