[Mesa-dev] [PATCH 12/15] gallium: Add winsys loader for device enumeration and driver multiplexing.

[Christian König]

On 26.03.2012 16:57, Jose Fonseca wrote:
> ----- Original Message -----
>> On 26.03.2012 14:56, Jose Fonseca wrote:
>>> This doesn't look like a "winsys" per se, but rather an auxiliary
>>> library to create winsys and screens, meant to be used by state
>>> trackers. Is this right?
>>>
>>> If so then I believe the right place would be somewhere
>>> src/gallium/auxiliary .
>>>
>>> Jose
>> The same is true for winsys/g3dvl, and I'm planning to move it under
>> auxiliary for quite some time, but unfortunately it has a dependency
>> on
>> X libs, and well something like this is a bit sensitive to put under
>> auxiliary. The same might be true for this winsys loader.
> I see.
>
> We could put this kind of modules in src/gallium/auxiliary/foo , but provide them as separate convenient libraries (i.e., libfoo.a, which are only built/linked as appropriate), as opposed to be bundled into libgallium.a (which should retain only cross-platform portable code).
>
> I think it would still be less confusing than having auxiliary libraries that are not winsys in src/gallium/winsys .

Agree with that. See the attached patch, the softpipe targets refereed 
to the winsys files manually anyway, so I just did the same with the DRI 
targets and be happy with it. What do you think?

On 26.03.2012 17:20, Francisco Jerez wrote:
> Essentially it's an interface to enumerate the graphic devices that are
> present in the system (and by extension to create screens on them,
> enumeration alone is useless without having a way to do something with
> the devices you find).
>
> You're right that traditionally this hasn't been part of the winsys API,
> but the task is very tightly coupled with the underlying window system:
> to my innocent eyes it seems that it would make more sense to extend the
> winsys API with something like this.

Well, they key point is that even if it is closely related to the 
different window systems, it isn't a window system of its own! So I 
would also rather put it under src/gallium/auxiliary/winsysloader instead.

Christian.