[Mesa-dev] [PATCH 1/4] mesa: add support for ARB_blend_func_extended

[Eric Anholt]

On Tue, 27 Mar 2012 07:43:44 +0100, Dave Airlie <airlied at gmail.com> wrote:
> On Mon, Mar 26, 2012 at 9:17 PM, Eric Anholt <eric at anholt.net> wrote:
> > On Mon, 26 Mar 2012 19:14:01 +0100, Dave Airlie <airlied at gmail.com> wrote:
> >> From: Dave Airlie <airlied at redhat.com>
> >>
> >> Add implementations of the two API functions,
> >> Add a new strings to uint mapping for index bindings
> >> Add the blending mode validation for SRC1 + SRC_ALPHA_SATURATE
> >> Add get for MAX_DUAL_SOURCE_DRAW_BUFFERS
> >>
> >> The GLSL patch will setup the indices.
> >
> > Given
> >
> >    The command
> >
> >        void BindFragDataLocation(uint program, uint colorNumber, const char * name)
> >
> >    is equivalent to calling BindFragDataLocationIndexed with the same values
> >    for <program>, <colorNumber> and <name>, and with <index> set to zero.
> >
> > it seems like you could avoid basically duplicating the existing
> > function by calling the new entrypoint.
> 
> I did :-), I have to say git diff has made the worst possible patch
> out of the code,
> it might be best to apply it and then read the result :)

Oops.  It was the changes to GetFragDataLocation/Index I was looking at
when I noticed duplication, and then I went and looked up how BFDLI
worked and talked about that instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120327/e143a28e/attachment.pgp>