No subject

Yuanhan Yuanhan
Tue Mar 27 12:14:21 PDT 2012

n.liu at</a>&gt;<br>
Date: Tue, 27 Mar 2012 15:41:52 +0800<br>
Subject: [PATCH] intel: fix un-blanced map_refcount issue<br>
This is a regression introduced by commit cdcfd5, which forget to<br>
increase the map_refcount for successfully-mapped region. Thus caused a<br>
wrong non-blanced map_refcount.<br>
This would fix the regression found in the two following webglc testcase<br=
on Pineview platform:<br>
 =A0 texture-npot.html<br>
 =A0 gl-max-texture-dimensions.html<br>
Cc: Anuj Phogat &lt;<a href=3D"mailto:anuj.phogat at">anuj.phogat at gm=</a>&gt;<br>
Signed-off-by: Yuanhan Liu &lt;<a href=3D"mailto:yuanhan.liu at
m">yuanhan.liu at</a>&gt;<br>
=A0src/mesa/drivers/dri/intel/intel_regions.c | =A0 =A08 ++++----<br>
=A01 files changed, 4 insertions(+), 4 deletions(-)<br>
diff --git a/src/mesa/drivers/dri/intel/intel_regions.c b/src/mesa/drivers/=
index d2b737b..abea2bd 100644<br>
--- a/src/mesa/drivers/dri/intel/intel_regions.c<br>
+++ b/src/mesa/drivers/dri/intel/intel_regions.c<br>
@@ -133,10 +133,10 @@ intel_region_map(struct intel_context *intel, struct =
intel_region *region,<br>
<div class=3D"im"> =A0 =A0 =A0 =A0 drm_intel_bo_map(region-&gt;bo, true);<b=
 =A0 =A0 =A0 region-&gt;map =3D region-&gt;bo-&gt;virtual;<br>
</div>- =A0 =A0 =A0if (region-&gt;map) {<br>
- =A0 =A0 =A0 =A0 intel-&gt;num_mapped_regions++;<br>
- =A0 =A0 =A0 =A0 region-&gt;map_refcount++;<br>
- =A0 =A0 =A0}<br>
+ =A0 }<br>
+ =A0 if (region-&gt;map) {<br>
+ =A0 =A0 =A0intel-&gt;num_mapped_regions++;<br>
+ =A0 =A0 =A0region-&gt;map_refcount++;<br>
 =A0 =A0}<br>
 =A0 =A0return region-&gt;map;<br>
<span class=3D"HOEnZb"><font color=3D"#888888">--<br><br>
</font></span></blockquote></div><div>Yes, I missed that. Thanks for fixing=
 it.</div>Reviewed-by: Anuj Phogat &lt;<a href=3D"mailto:anuj.phogat at gmail.=
com">anuj.phogat at</a>&gt;


More information about the mesa-dev mailing list