[Mesa-dev] [PATCH] linker: Fix memory leak in count_uniform_size::visit_field.

[Kenneth Graunke]

On 03/28/2012 11:43 PM, Vinson Lee wrote:
> Fixes a Coverity resource leak defect.
>
> NOTE: This is a candidate for the 8.0 branch.
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>
> ---
>   src/glsl/link_uniforms.cpp |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
> index 613c9b7..86717f9 100644
> --- a/src/glsl/link_uniforms.cpp
> +++ b/src/glsl/link_uniforms.cpp
> @@ -175,6 +175,7 @@ private:
>
>         char *key = strdup(name);
>         this->map->put(this->num_active_uniforms, key);
> +      free(key);
>
>         /* Each leaf uniform occupies one entry in the list of active
>          * uniforms.

It looks like string_to_uint_map::put (hash_table.h:247) already calls 
strdup() on the key.  So I think we should just do:

         this->map->put(this->num_active_uniforms, name);

and not bother duplicating it twice.