[Mesa-dev] [PATCH] meta: do fallback when texture is enabled for DrawPixels

[Liu Aleaxander]

On Sat, May 5, 2012 at 9:44 AM, Roland Scheidegger <sroland at vmware.com> wrote:
[snip]...

>> +    * or the original texture stuff would not work
>> +    *
>> +    * FIXME: we may use multi-texture to handle this case. But fallback is
>> +    * definitely a much simple and straight way.
>> +    */
>> +   if (ctx->Texture._EnabledUnits)
>> +      fallback = GL_TRUE;
>> +
>>     if (_mesa_is_color_format(format)) {
>>        /* use more compact format when possible */
>>        /* XXX disable special case for GL_LUMINANCE for now to work around
>
> Wouldn't you also have to test for active fragment shader too (i.e.
> essentially same test that _mesa_meta_Bitmap is doing I think they might
> have the same prerequisites for fallback for the hilarious combination
> of these ops with ordinary fragment shading)? Though I guess maybe you
> could avoid fallback in some cases (like drawing to stencil buffer then
> texture bound shouldn't matter I think though a fragment shader writing
> to depth or killing fragments still would).

Yes and thanks. And here is the new patch based on your comments: