[Mesa-dev] [PATCH] mesa: Use the proper feature test macros for strtod_l and strtof[_l].

Bryan Henderson bryanh at giraffe-data.com
Fri May 11 08:58:06 PDT 2012


>Android does not have strtod_l. Yet, the old co de successfully compiled
>because Android does not define _GNU_SOURCE.

Just to make sure we're all on the same page: NOBODY defines _GNU_SOURCE.
At least they shouldn't.  Used correctly, _GNU_SOURCE is something that gets
defined by a #define in the source file which wants to declare itself as
coded for nonstandard GNU features of libc.

And so I have to ask about <xlocale.h>.  The original code says to include
that if both _GNU_SOURCE and __APPLE__ are defined, which I presume is never.
The current patch says to include it if both __GLIBC__ and __APPLE__ are
defined, which again appears to be never.  I don't know what <xlocale.h> is;
who needs it?

-- 
Bryan Henderson                                   San Jose, California


More information about the mesa-dev mailing list