[Mesa-dev] [PATCH] vl: Initialize pipe_vertex_buffer.user_buffer fields.

[Marek Olšák]

On Mon, May 14, 2012 at 12:14 PM, Christoph Bumiller
<e0425955 at student.tuwien.ac.at> wrote:
> On 14.05.2012 09:25, Jose Fonseca wrote:
>> Looks good. Thanks Vinson.
>>
>> Joe
>
> Actually, all the user_buffer pointers have a comment "/**< pointer to a
> user buffer if buffer == NULL */", so you wouldn't actually have to
> initialize them if buffer is guaranteed to be non-NULL, and checking for
> user_buffer before buffer anywhere would be a bug ... but then, we can't
> rely on people to recognize that, can we.

The comment is wrong. If either one is non-NULL, the other one must be NULL.

Marek