[Mesa-dev] [PATCH] i965: Gut the separate OpenGL ES extension enabling.
Chad Versace
chad.versace at linux.intel.com
Wed May 16 09:35:54 PDT 2012
On 05/15/2012 03:49 PM, Kenneth Graunke wrote:
> We should just set the bits of functionality that we support; the
> GL/ES1/ES2 flags in extensions.c will take care of advertising the
> appropriate extensions for the current API.
>
> This enables the GL_EXT_texture_compression_dxt1 extension on ES1/ES2
> when libtxc_dxtn is installed or the force_s3tc driconf option is set.
> The main extension code set this up properly, but the ES-specific code
> failed to do so.
>
> Otherwise, the extension strings reported by es1_info, es2_info, and
> glxinfo all remain the same.
>
> This patch manually disables the ARB_framebuffer_object bit on ES
> to preserve the behavior of 1c0f5d8324c4db2720247989ddc4a45315b55a85.
>
> Cc: Daniel Charles <daniel.charles at intel.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
> src/mesa/drivers/dri/i915/Makefile.sources | 1 -
> src/mesa/drivers/dri/i915/intel_extensions_es.c | 1 -
> src/mesa/drivers/dri/i965/Makefile.sources | 1 -
> src/mesa/drivers/dri/i965/intel_extensions_es.c | 1 -
> src/mesa/drivers/dri/intel/intel_context.c | 12 +-
> src/mesa/drivers/dri/intel/intel_extensions.c | 7 +-
> src/mesa/drivers/dri/intel/intel_extensions_es.c | 132 ----------------------
> 7 files changed, 7 insertions(+), 148 deletions(-)
> delete mode 120000 src/mesa/drivers/dri/i915/intel_extensions_es.c
> delete mode 120000 src/mesa/drivers/dri/i965/intel_extensions_es.c
> delete mode 100644 src/mesa/drivers/dri/intel/intel_extensions_es.c
The code looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
More information about the mesa-dev
mailing list