[Mesa-dev] [PATCH 09/15] i965/blorp: Enable blorp blits on Gen7.

Chad Versace chad.versace at linux.intel.com
Tue May 22 11:47:33 PDT 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/11/2012 11:03 AM, Paul Berry wrote:
> Gen7 support for blorp (blits using the render bath) now works for
> non-MSAA purposes.  This patch enables it.
> 
> Since blorp operations re-use the logic for HiZ ops, this required
> adding a case to the switch statement in gen7_blorp_emit_wm_config(),
> to allow for the case where no HiZ op is being performed.
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_blit.cpp |    4 ++--
>  src/mesa/drivers/dri/i965/gen7_blorp.cpp     |    2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)


This is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

I like that you chose to define a token for the no-op rather
than equating the no-op with the default case.

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPu99EAAoJEAIvNt057x8ieT4QAJFh/7unNaju1dSVGs5YpJcu
q0rYJH01E/CtY+mH8KsFhc0Ww8n8En+9jjAQnOgGH6mvB6C+ilyxYXVEcMx8ymjX
4GqLn/G79HH+1kIxqNwKG1l+4asdLpawOPmaDnG4PVrwOTAvPggpHio2ip72dwGZ
3nwwO7MBYVsLVxnJzuZTFNhBfdmtz9gKDKy5L9fK3dlUgKgZgkRuaACFo0M5NNq+
W+Tcsz4BaEkGjpAwDfmvni6cUVMPy8edSyxVJZarNKvuKjOMv/4Pf8xkmbxm2iKS
aK3Z1YkNc8K3e33rUoWudMJD/hL45fBeQU5xx9JoONKpVcIJ0BCaVgpWsOGh2ZnC
+PNfphsqMfVlq+1nbjG93r//s7NGawYuOVxaoM6aOcBlaX5an8cnGN5JZlKOI99b
5slAEXb08HNG8sQsc3icpAUmfIasHQoWLUs1fknm7vKut/LfXP0D/x9UKcAlfQU8
vwghTuzw4IFF3kiGDghJGW0gkNkZGLZOyDXZnVQhuhKURa+jOibwsRyVlk68ak72
yEi4dWpzH+Y8xI99ZSjlCDHCGWmEjglPjh0w0SOBXBd7VWWomXBbcxDoaLB5qemI
VwqBYx6jhLY0lFJbu6NtuC4fKvfijl+9DPHOrMVd5219n15fauPCATg6UCHKyPo9
ZJiKqslg4IfUH2c+mYgh
=6tUB
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list