[Mesa-dev] [PATCH 1/1] mesa: initial work for OES_vertex_type_10_10_10_2 extension support.

Oliver McFadden oliver.mcfadden at linux.intel.com
Tue May 22 23:00:20 PDT 2012


On Tue, May 22, 2012 at 07:32:57AM -0600, Brian Paul wrote:
> On 05/22/2012 03:52 AM, Oliver McFadden wrote:
> > On Tue, May 22, 2012 at 10:02:59AM +0100, Dave Airlie wrote:
> >> just a observation below,
> >>> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> >>> index efa63b0..376e62f 100644
> >>> --- a/src/mesa/main/varray.c
> >>> +++ b/src/mesa/main/varray.c
> >>> @@ -61,6 +61,8 @@
> >>>   #define FIXED_GL_BIT         0x800
> >>>   #define UNSIGNED_INT_2_10_10_10_REV_BIT 0x1000
> >>>   #define INT_2_10_10_10_REV_BIT 0x2000
> >>> +#define UNSIGNED_INT_10_10_10_2_OES_BIT 0x8000
> >>> +#define INT_10_10_10_2_OES_BIT 0x10000
> >>
> >> You skipped 0x4000 here for a reason?
> >
> > Oops, that was a mistake. Thanks for pointing that out.
> >
> > If everything else is OK and I get some Reviewed-by's I'll fix that up
> > and push it.
> >
> 
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> Which driver(s) do you intend to support this in?

i965, but the driver code has bugs at the moment.

-- 
Oliver McFadden.


More information about the mesa-dev mailing list