[Mesa-dev] [PATCH] gallium/targets: pass ldflags parameter to MKLIB

Brian Paul brianp at vmware.com
Fri May 25 08:36:41 PDT 2012


On 05/23/2012 10:55 AM, Thomas Gstädtner wrote:
> Without passing the -ldflags parameter before $(LDFLAGS) in some cases
> flags will be passed to MKLIB which it does not understand.
> This might be -m64, -m32 or similar.
>
> Signed-off-by: Thomas Gstädtner<thomas at gstaedtner.net>
> ---
>   src/gallium/targets/Makefile.xorg |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/gallium/targets/Makefile.xorg b/src/gallium/targets/Makefile.xorg
> index 481e3d6..21bf237 100644
> --- a/src/gallium/targets/Makefile.xorg
> +++ b/src/gallium/targets/Makefile.xorg
> @@ -46,7 +46,7 @@ endif
>   default: depend $(TOP)/$(LIB_DIR)/gallium $(LIBNAME) $(LIBNAME_STAGING)
>
>   $(LIBNAME): $(OBJECTS) Makefile ../Makefile.xorg $(LIBS) $(DRIVER_PIPES) $(GALLIUM_AUXILIARIES)
> -	$(MKLIB) -linker '$(LD)' -noprefix -o $@ $(LDFLAGS) $(OBJECTS) $(DRIVER_PIPES) $(GALLIUM_AUXILIARIES) $(DRIVER_LINKS)
> +	$(MKLIB) -linker '$(LD)' -noprefix -o $@ -ldflags '$(LDFLAGS)' $(OBJECTS) $(DRIVER_PIPES) $(GALLIUM_AUXILIARIES) $(DRIVER_LINKS)
>
>   depend: $(C_SOURCES) $(CPP_SOURCES) $(ASM_SOURCES) $(SYMLINKS) $(GENERATED_SOURCES)
>   	rm -f depend

Looks good.  I'll push it shortly.

-Brian


More information about the mesa-dev mailing list