[Mesa-dev] [PATCH 23/26] glapi: Remove GL_APPLE_texture_range from the dispatch table

Ian Romanick idr at freedesktop.org
Tue May 29 15:51:50 PDT 2012


From: Ian Romanick <ian.d.romanick at intel.com>

There is no GLX protocol for these functions, and no Linux driver has
ever supported this extension.  There's no reason to have slots for
these functions in the dispatch table.

The unit test is also updated.  The odd side effect here is the test
GetProcAddress::TableAsBigAsAt_git_b45052b now really has nothing to
do with GIT SHA1 b45052b.  This is why the new value is '978u - 2u'.
GIT SHA1 b45052b had 978 entries, and two are removed by this change.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 src/mapi/glapi/gen/gl_API.xml        |    4 ++--
 src/mapi/glapi/tests/check_table.cpp |    7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index e0c5b8a..97056b5 100644
--- a/src/mapi/glapi/gen/gl_API.xml
+++ b/src/mapi/glapi/gen/gl_API.xml
@@ -12410,12 +12410,12 @@
     <enum name="TEXTURE_RANGE_POINTER_APPLE" count="1" value="0x85B8">
         <size name="GetTexParameterPointervAPPLE" mode="get"/>
     </enum>
-    <function name="TextureRangeAPPLE" offset="assign" static_dispatch="false">
+    <function name="TextureRangeAPPLE">
         <param name="target" type="GLenum"/>
         <param name="length" type="GLsizei"/>
         <param name="pointer" type="GLvoid *"/>
     </function>
-    <function name="GetTexParameterPointervAPPLE" offset="assign" static_dispatch="false">
+    <function name="GetTexParameterPointervAPPLE">
         <param name="target" type="GLenum"/>
         <param name="pname" type="GLenum"/>
         <param name="params" type="GLvoid **"/>
diff --git a/src/mapi/glapi/tests/check_table.cpp b/src/mapi/glapi/tests/check_table.cpp
index d35dd3d..c4627f8 100644
--- a/src/mapi/glapi/tests/check_table.cpp
+++ b/src/mapi/glapi/tests/check_table.cpp
@@ -82,8 +82,11 @@ TEST(GetProcAddress, TableAsBigAsAt_git_b45052b)
     *
     * 1 entry was removed when GL_SGIX_pixel_texture was removed from the
     * dispatch table.
+    *
+    * 2 entries were removed when GL_APPLE_texture_range was removed from the
+    * dispatch table.
     */
-   EXPECT_GE(table_entries, 978u - 6u - 1u);
+   EXPECT_GE(table_entries, 978u - 6u - 1u - 2u);
 }
 
 TEST(GetProcAddress, QueriedDispatchSizeBigEnough)
@@ -1501,8 +1504,6 @@ const struct name_offset known_dispatch[] = {
    { "glGetTransformFeedbackVaryingEXT", _O(GetTransformFeedbackVaryingEXT) },
    { "glTransformFeedbackVaryingsEXT", _O(TransformFeedbackVaryingsEXT) },
    { "glProvokingVertexEXT", _O(ProvokingVertexEXT) },
-   { "glGetTexParameterPointervAPPLE", _O(GetTexParameterPointervAPPLE) },
-   { "glTextureRangeAPPLE", _O(TextureRangeAPPLE) },
    { "glGetObjectParameterivAPPLE", _O(GetObjectParameterivAPPLE) },
    { "glObjectPurgeableAPPLE", _O(ObjectPurgeableAPPLE) },
    { "glObjectUnpurgeableAPPLE", _O(ObjectUnpurgeableAPPLE) },
-- 
1.7.6.5



More information about the mesa-dev mailing list