[Mesa-dev] [PATCH 00/26] Unit test generated code, fix bugs

[Brian Paul]

On 05/29/2012 04:51 PM, Ian Romanick wrote:
> This series contains four bits of stuff:
>
> Patches 01/26 and 02/26 move the existing GLX tests from tests/glx to
> src/glx/tests.  This matches the placement of the other unit tests in
> Mesa.
>
> Patches 03/26, 04/26, 19/26, and 20/26 add new tests for code
> generated from XML descriptions of the OpenGL and GLX APIs.  These
> test indirect_size.c and indirect_init.c in src/glx,
> _mesa_lookup_enum_by_{name,nr} in src/mesa/main/enums.c, and the
> dispatch tables in src/mapi/glapi.
>
> Patches 05/26 through 18/26 fix minor bugs in
> _mesa_lookup_enum_by_{name,nr} found with using the unit tests.  The
> fixes appear in the sequence before the test cases so that, during a
> bisect, 'make check' will always pass.

These look good to me.  Reviewed-by: Brian Paul <brianp at vmware.com>


> Patches 21/26 through 26/26 remove some functions from the dispatch
> table that are dead on arrival.  The unit tests give some assurance
> that this change won't break things.

Looks good too.  Reviewed-by: Brian Paul <brianp at vmware.com>

BTW, GL_SGIX_pixel_texture was actually implemented in Mesa for a 
while some years ago.

-Brian