[Mesa-dev] [PATCH 20/26] mesa/tests: Add tests for the generated dispatch table

Eric Anholt eric at anholt.net
Wed May 30 15:19:27 PDT 2012


On Tue, 29 May 2012 15:51:47 -0700, "Ian Romanick" <idr at freedesktop.org> wrote:
> +TEST(GetProcAddress, ABINameByOffset)
> +{
> +   /* 408 functions have had their locations in the dispatch table set since
> +    * the danw of time.  Verify that all of these functions are at the correct
             ^dawn

(also copy and pasted)

I don't like the "as big as at some git sha1" test given that you
immediately go on to show that the test is invalid and just hack around
it.  That sounds to me like "this test should be removed".  Maybe just
check that it's bigger than the fixed ABI?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120530/5c0c6b0b/attachment.pgp>


More information about the mesa-dev mailing list