[Mesa-dev] [PATCH 6/9] dispatch: Make a header to go along with querymatrix.c.

Chad Versace chad.versace at linux.intel.com
Thu Nov 1 10:21:00 PDT 2012


On 10/31/2012 05:37 PM, Paul Berry wrote:
> On 31 October 2012 15:27, Chad Versace <chad.versace at linux.intel.com
> <mailto:chad.versace at linux.intel.com>> wrote:
> 
>     On 10/30/2012 10:42 AM, Paul Berry wrote:
>     > This patch creates a header querymatrix.h, to allow functions defined
>     > in querymatrix.c to be used from other .c files.  It also switches
>     > from the nonstandard GL_APIENTRY to GLAPIENTRY.
>     > ---
>     >  src/mesa/main/querymatrix.c | 12 +++++-------
>     >  src/mesa/main/querymatrix.h | 39 +++++++++++++++++++++++++++++++++++++++
>     >  2 files changed, 44 insertions(+), 7 deletions(-)
>     >  create mode 100644 src/mesa/main/querymatrix.h
>     >
>     > diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c
>     > index 2843d55..27842ae 100644
> 
>     > +extern void GLAPIENTRY _mesa_GetIntegerv(GLenum pname, GLint *params);
>     > +extern void GLAPIENTRY _mesa_GetFloatv(GLenum pname, GLfloat *params);
> 
>     I think the local declarations of the Get functions should be removed. Instead,
>     just #include "main/get.h".
> 
> 
> Yeah, that seems reasonable.  I'll make that change before pushing the series.

Thanks.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the mesa-dev mailing list