[Mesa-dev] [PATCH v2 06/13] mesa: disable ProgramParameteri until ARB_geometry_shader4 is supported

[Paul Berry]

On 30 October 2012 11:25, Jordan Justen <jordan.l.justen at intel.com> wrote:

> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/main/shaderapi.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
> index 04cdfba..a8be5c5 100644
> --- a/src/mesa/main/shaderapi.c
> +++ b/src/mesa/main/shaderapi.c
> @@ -1732,10 +1732,6 @@ _mesa_init_shader_dispatch(const struct gl_context
> *ctx,
>     SET_GetActiveAttribARB(exec, _mesa_GetActiveAttribARB);
>     SET_GetAttribLocationARB(exec, _mesa_GetAttribLocationARB);
>
> -   if (ctx->API != API_OPENGLES2) {
> -      SET_ProgramParameteri(exec, _mesa_ProgramParameteriARB);
> -   }
> -
>     if (ctx->API != API_OPENGLES2 && ctx->API != API_OPENGL_CORE) {
>        SET_UseShaderProgramEXT(exec, _mesa_UseShaderProgramEXT);
>        SET_ActiveProgramEXT(exec, _mesa_ActiveProgramEXT);
> --
> 1.7.9.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>

I'd recommend changing the subject line and the commit message to reflect
the fact that ProgramParameteri() is *also* required for GLES3 (it's used
to access the PROGRAM_BINARY_RETRIEVABLE_HINT, which tells GLES3 that the
client is likely to want to retrieve a program binary using the
GetProgramBinary() function).

With the subject and commit message updated, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121102/007de924/attachment-0001.html>