[Mesa-dev] [PATCH 00/27] intel: Add ETC2 compressed textures support

[Ian Romanick]

On 10/19/2012 04:28 PM, Anuj Phogat wrote:
> This series lives on my etc2-v9 branch (https://github.com/aphogat/mesa).
>
> This series enables 8 out of 10 ETC2 texture formats for all Intel
> hardware by simply decoding the ETC2 data into RGBX data at the time
> of glCompressedTexImage2D. These patches can be tested using piglit
> test case i have added for etc2 textures. Patches for the test are under
> review on piglit mailing list.
>
> I'll soon post the patches for remaining 2 etc2 formats as well.

I've sent review comments for a bunch of the patches.  The only thing 
that I'm really concerned about is the sRGB issue.  Decoding compressed 
sRGB textures to uncompressed RGB is probably not right.  I believe that 
those should all be decoded to uncompressed sRGB.  Other than changing 
around where some enums are in switch statements, I think that will 
actually simplify the code... no need to do software sRGB decoding. :)

> Anuj Phogat (27):
>    mesa: Use MESA_GL_VERSION_OVERRIDE in compute_version_es2()
>    mesa: Add a new texture format GL_COMPRESSED_RGB8_ETC2
>    mesa: Add decoding functions for GL_COMPRESSED_RGB8_ETC2
>    intel: Enable the support for GL_COMPRESSED_RGB8_ETC2 textures
>    mesa: Add necessary support to decode multiple ETC2 texture formats
>    intel: Add necessary support to decode multiple ETC2 texture formats
>    mesa: Add a new texture format GL_COMPRESSED_SRGB8_ETC2
>    mesa: Add decoding functions for GL_COMPRESSED_SRGB8_ETC2
>    intel: Enable support for GL_COMPRESSED_SRGB_ETC2 textures
>    mesa: Add a new texture format GL_COMPRESSED_RGBA8_ETC2_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_RGBA8_ETC2_EAC
>    intel: Enable support for GL_COMPRESSED_RGBA8_ETC2_EAC textures
>    mesa: Add a new texture format GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC
>    intel: Enable support for GL_COMPRESSED_SRGB8_ALPHA8_ETC2_EAC
>      textures
>    Add a new texture format GL_COMPRESSED_R11_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_R11_EAC
>    intel: Enable support for GL_COMPRESSED_R11_EAC textures
>    Add a new texture format GL_COMPRESSED_RG11_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_RG11_EAC
>    intel: Enable support for GL_COMPRESSED_RG11_EAC textures
>    Add a new texture format GL_COMPRESSED_SIGNED_R11_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_SIGNED_R11_EAC
>    intel: Enable support for GL_COMPRESSED_SIGNED_R11_EAC textures
>    mesa: Add a new texture format GL_COMPRESSED_SIGNED_RG11_EAC
>    mesa: Add decoding functions for GL_COMPRESSED_SIGNED_RG11_EAC
>    intel: Enable support for GL_COMPRESSED_SIGNED_RG11_EAC textures
>
>   src/mesa/drivers/dri/i965/brw_wm_surface_state.c |   12 +
>   src/mesa/drivers/dri/intel/intel_mipmap_tree.c   |   96 ++-
>   src/mesa/drivers/dri/intel/intel_mipmap_tree.h   |   21 +-
>   src/mesa/main/format_unpack.c                    |   57 +-
>   src/mesa/main/formats.c                          |  109 ++
>   src/mesa/main/formats.h                          |    8 +
>   src/mesa/main/glformats.c                        |   17 +
>   src/mesa/main/texcompress.c                      |   83 ++
>   src/mesa/main/texcompress_etc.c                  | 1159 +++++++++++++++++++++-
>   src/mesa/main/texcompress_etc.h                  |   63 ++-
>   src/mesa/main/texformat.c                        |   31 +
>   src/mesa/main/teximage.c                         |   19 +
>   src/mesa/main/texstore.c                         |    8 +
>   src/mesa/main/version.c                          |    2 +
>   14 files changed, 1666 insertions(+), 19 deletions(-)
>