[Mesa-dev] [PATCH 05/11] softpipe: Fix rgb_dst_factor == PIPE_BLENDFACTOR_SRC_ALPHA_SATURATE.

[Brian Paul]

On 11/07/2012 08:26 AM, jfonseca at vmware.com wrote:
> From: José Fonseca<jfonseca at vmware.com>
>
> We must multiply the factor against the destination, not the source.
> ---
>   src/gallium/drivers/softpipe/sp_quad_blend.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/drivers/softpipe/sp_quad_blend.c b/src/gallium/drivers/softpipe/sp_quad_blend.c
> index aba6730..b85431d 100644
> --- a/src/gallium/drivers/softpipe/sp_quad_blend.c
> +++ b/src/gallium/drivers/softpipe/sp_quad_blend.c
> @@ -568,9 +568,9 @@ blend_quad(struct quad_stage *qs,
>            float diff[4], temp[4];
>            VEC4_SUB(diff, one, blend_dest[3]);
>            VEC4_MIN(temp, alpha, diff);
> -         VEC4_MUL(blend_dest[0], quadColor[0], temp); /* R */
> -         VEC4_MUL(blend_dest[1], quadColor[1], temp); /* G */
> -         VEC4_MUL(blend_dest[2], quadColor[2], temp); /* B */
> +         VEC4_MUL(blend_dest[0], blend_dest[0], temp); /* R */
> +         VEC4_MUL(blend_dest[1], blend_dest[1], temp); /* G */
> +         VEC4_MUL(blend_dest[2], blend_dest[2], temp); /* B */
>         }
>         break;
>      case PIPE_BLENDFACTOR_CONST_COLOR:

Candidate for 9.0 branch?

-Brian