[Mesa-dev] [PATCH] mesa: expand the fragprog_inputs_read bitfield in ffvertex_prog.c

[Brian Paul]

On 11/07/2012 10:18 AM, Eric Anholt wrote:
> Brian Paul<brianp at vmware.com>  writes:
>
>> The glean glsl1 test was failing an assertion because FRAG_ATTRIB_FACE
>> (and FRAG_ATTRIB_PNTC) doesn't fit in a 12-bit field.
>>
>> In the failing case we're using a fragment shader with fixed-function
>> vertex processing.
>
> What about if they have an FS reading generic attribs, and forget to
> bind a VS.  Should they still assertion fail?

I modified the glean test to also read a 'foo' varying var in the FS 
and I didn't see a failure.

>
> This code only cares about some low bits, it doesn't matter what the
> high ones are.

So you're saying just mask-off the high bits?

-Brian