[Mesa-dev] [PATCH 2/7] glcpp: don't push #line directives into next line

Kenneth Graunke kenneth at whitecape.org
Thu Nov 8 23:24:02 PST 2012


On 11/08/2012 05:26 PM, Matt Turner wrote:
> From: Fabian Bieler <fabianbieler at fastmail.fm>
>
> mattst88: Carl and I determined independently of Fabian that the 091
> test needed to be modified identically to this, and our patch to fix the
> test was more complicated.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51506
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> ---
> Patch 1/7 is "glcpp: Reject garbage after #else and #endif tokens"

Wow, this patch so looks like superfluous code motion.  By moving it out 
of the control_line production rule and into line:, we avoid the 
appending of \n caused by the control_line's action.

Would you mind adding something t othat effect to the commit message?

Either way, this series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list