[Mesa-dev] [PATCH 1/3] glapi: add GL4x.xml

[Jordan Justen]

On Thu, Nov 8, 2012 at 4:30 PM, Ian Romanick <idr at freedesktop.org> wrote:
> As far as I can tell, there's no purpose in this until we add support for GL
> 4.x... and that's quite some time away.

That is true. There is no need for this at this time.

I just thought I'd get some of these tedious changes made, and convert
some extension based functions to alias the core name. (Didn't we want
to cleanup mesa_name="-ARB" in the xml, for instance?)

> This also goes against our policy
> of not committing support for a piece of functionality until it can actually
> be enabled at least to a point where some test case could run.

Functionality wise:
1/3: nop
2/3: New dispatch entry created, but it should not be set
3/3: Core names created, and extensions were aliased back to them.
Don't we allow for future core functions to be set when they are
aliases of a supported extension?

Thanks,

-Jordan

> On 11/08/2012 01:57 PM, Jordan Justen wrote:
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>> ---
>>   src/mapi/glapi/gen/GL4x.xml    |   16 ++++++++++++++++
>>   src/mapi/glapi/gen/Makefile.am |    3 ++-
>>   src/mapi/glapi/gen/gl_API.xml  |    2 ++
>>   3 files changed, 20 insertions(+), 1 deletion(-)
>>   create mode 100644 src/mapi/glapi/gen/GL4x.xml
>>
>> diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml
>> new file mode 100644
>> index 0000000..4db195e
>> --- /dev/null
>> +++ b/src/mapi/glapi/gen/GL4x.xml
>> @@ -0,0 +1,16 @@
>> +<?xml version="1.0"?>
>> +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd">
>> +
>> +<!-- Note: no GLX protocol info yet. -->
>> +
>> +<OpenGLAPI>
>> +
>> +<category name="4.0">
>> +
>> +</category>
>> +
>> +<category name="4.3">
>> +
>> +</category>
>> +
>> +</OpenGLAPI>
>> diff --git a/src/mapi/glapi/gen/Makefile.am
>> b/src/mapi/glapi/gen/Makefile.am
>> index 13943e8..9acd03b 100644
>> --- a/src/mapi/glapi/gen/Makefile.am
>> +++ b/src/mapi/glapi/gen/Makefile.am
>> @@ -133,7 +133,8 @@ API_XML = \
>>         NV_primitive_restart.xml \
>>         NV_texture_barrier.xml \
>>         OES_EGL_image.xml \
>> -       GL3x.xml
>> +       GL3x.xml \
>> +       GL4x.xml
>>
>>
>>   COMMON = $(API_XML) \
>> diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
>> index 01d2a9c..71971dd 100644
>> --- a/src/mapi/glapi/gen/gl_API.xml
>> +++ b/src/mapi/glapi/gen/gl_API.xml
>> @@ -13056,4 +13056,6 @@
>>
>>   <xi:include href="ARB_get_program_binary.xml"
>> xmlns:xi="http://www.w3.org/2001/XInclude"/>
>>
>> +<xi:include href="GL4x.xml" xmlns:xi="http://www.w3.org/2001/XInclude"/>
>> +
>>   </OpenGLAPI>
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev