[Mesa-dev] [PATCH v2 00/22] intel: Add ETC2 compressed texture support

[Brian Paul]

On 11/10/2012 12:29 AM, Anuj Phogat wrote:
> This series lives on my gles3-etc2-v2 branch (https://github.com/aphogat/mesa).
>
> It enables ETC2 texture formats for all Intel hardware. ETC2 texture
> data is decoded into a suitable uncompressed mesa format at the time
> of glCompressedTexImage2D. These patches can be tested using piglit
> test case i have posted for etc2 textures. Patches for the test are
> under review on piglit mailing list.
>
> Major changes based on review comments by Brian and Ian:
>   - Now decodes SRGB ETC2 formats to MESA_FORMAT_SARGB.
>   - Fixed an issue with signed-{r, rg}11 decoding. Decoded 16 bit signed
>     data is now converted to 16 bit unsigned data by adding 2 ^ 15 and
>     stored in an unsigned mesa texture format. This makes piglit etc2
>     test case pass for these formats.
>   - Added entries to texfetch_funcs[] array. ETC2 piglit test passes on
>     swrast.
>   - Squashed together all patches to enable etc2 formats on intel h/w.
>   - Now uses nonlinear_to_linear() function to convert from SRGB to
>     linear RGB.
>
> I'll soon be pushing this series on gles3 branch.
>

This looks pretty good overall.  Quite a bit of work.

I had a few comments and they often apply to several subsequent patches.

-Brian