[Mesa-dev] mesa : ARB_texture_gather implementation - WIP[PATCH1/1] but need advice !

[Kenneth Graunke]

On 11/12/2012 09:03 PM, Maxence Le Doré wrote:
> Here is a patch against master branch that takes a good way to implement
> ARB_texture_gather over softpipe but I have the regret to announce that
> I can't find what i'm doing wrong at a point :
>
> At compilation time, more precisely glsl code compilation, a file
> "builtin_function.cpp" is generated by python scripts, feed
> .glsl/.frag/.vert./.ir files. I've done created the file that declares
> the texture gather builtin functions and modified the python scripts
> that generated IR for texture functions. But the buitin compiler
> complains about wrong prototypes and leads to the production of a
> invalid builtin_function.cpp file.
>
> It's a little more irritating when I have the feeling to have exactly
> done as Dave Airlied has done to implement ARB_texture_cube_map_array
> builtins GLSL func few days ago. But that's wrong and I can figure out.
>
> It sounds silly even to myself. I'm pretty sure it's a lack of attention
> from me but i'm really blocked.

I'd be happy to help try and debug it, but...what did you try?  Your 
patch needs to add new 
src/glsl/builtins/profiles/ARB_texture_gather.(frag|vert) files 
containing the new prototypes.