[Mesa-dev] [PATCH] VertexAttribDivisor returns INVALID_VALUE if index is out of range

[Kenneth Graunke]

On 11/13/2012 01:32 PM, Matt Turner wrote:
> On Tue, Nov 13, 2012 at 1:29 PM, Paul Berry <stereotype441 at gmail.com> wrote:
>> On 13 November 2012 13:18, Matt Turner <mattst88 at gmail.com> wrote:
>>>
>>> All the other range checks on index already return the proper error,
>>> INVALID_VALUE.
>>>
>>> Fixes gles3conform's instanced_arrays_invalid.
>>
>>
>> Minor nit pick: it's not obvious from your commit subject whether it
>> describes the state of the code before or after the change.  I'd recommend
>> something like "mesa: return INVALID_VALUE from VertexAttribDivisor if index
>> out of range".
>
> Sure, that does sound better. Thanks!
>
>> Reviewed-by: Paul Berry <stereotype441 at gmail.com>

I agree with Paul.  Thanks for fixing these, Matt!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>