[Mesa-dev] [PATCH 6/9] intel: Push face/level -> slice handling to the caller of get_image_offset().

Chad Versace chad.versace at linux.intel.com
Tue Nov 13 15:14:30 PST 2012


On 11/05/2012 04:48 PM, Eric Anholt wrote:
> We were always passing 0 for one of the two fields, and the code just used
> whichever one wasn't 0.
> ---
>  src/mesa/drivers/dri/i915/i830_texstate.c       |    2 +-
>  src/mesa/drivers/dri/i965/brw_blorp.cpp         |    2 +-
>  src/mesa/drivers/dri/intel/intel_blit.c         |    1 -
>  src/mesa/drivers/dri/intel/intel_fbo.c          |    1 -
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.c  |   47 +++++++----------------
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.h  |    2 +-
>  src/mesa/drivers/dri/intel/intel_tex_copy.c     |    1 -
>  src/mesa/drivers/dri/intel/intel_tex_image.c    |    2 +-
>  src/mesa/drivers/dri/intel/intel_tex_subimage.c |    2 +-
>  src/mesa/drivers/dri/intel/intel_tex_validate.c |    4 +-
>  10 files changed, 20 insertions(+), 44 deletions(-)

Nice. I wanted to make this change a long time ago, but didn't.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the mesa-dev mailing list