[Mesa-dev] mesa : ARB_texture_gather implementation - WIP[PATCH1/1] but need advice !

Kenneth Graunke kenneth at whitecape.org
Tue Nov 13 16:02:13 PST 2012


On 11/13/2012 01:44 PM, Maxence Le Doré wrote:
[snip]
> diff --git a/src/glsl/ir.h b/src/glsl/ir.h
> index 89c516c..5d5b56d 100644
> --- a/src/glsl/ir.h
> +++ b/src/glsl/ir.h
> @@ -1334,7 +1334,8 @@ enum ir_texture_opcode {
>      ir_txl,        /**< Texture look-up with explicit LOD */
>      ir_txd,        /**< Texture look-up with partial derivatvies */
>      ir_txf,        /**< Texel fetch with explicit LOD */
> -   ir_txs        /**< Texture size */
> +   ir_txs,        /**< Texture size */
> +   ir_txg        /**< Texture gathering */
>   };

Or ir_tex_gather.

<idr> Most of the shorter names got picked because the matched existing, 
well known, assembly opcodes.
<idr> I don't think that applies here.

Up to you.


More information about the mesa-dev mailing list