[Mesa-dev] [PATCH 4/9] intel: Fix software copying of miptree faces for weird formats.

Eric Anholt eric at anholt.net
Tue Nov 13 17:41:15 PST 2012


Chad Versace <chad.versace at linux.intel.com> writes:

> Some weird formats are omitted: ETC1. This patch will raise an assertion
> if intel_miptree_copy_slice is called on an ETC1 texture and intelEmitCopyBlit
> fails. However, I'm not certain if copy_slice can even be called on ETC1.

It can :(

Set up for mipmap filtering.
Make a 5x5 level 0 image
Fill levels 1-3 with 4x4, 2x2, and 1x1.
Replace level 0 with an 8x8 image.
Render from the texture.

The driver has had to store those images in separate miptrees because
you did something stupid that GL lets you do because GL's texture upload
API is godawful.  Now the driver gets to merge these things into a
single miptree.

(You can even hit this path without doing really stupid things, if
guess_and_alloc guesses that you're not going to mipmap when you set up
level 0, and then you go add other levels)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121113/7ca50ae8/attachment.pgp>


More information about the mesa-dev mailing list