[Mesa-dev] [PATCH] mesa: Require gen'd names in glBeginQuery on ES 3.0.

Matt Turner mattst88 at gmail.com
Mon Nov 19 10:33:57 PST 2012


On Sat, Nov 17, 2012 at 8:56 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Only legacy OpenGL allows the use of non-gen'd names.  Core profiles
> and ES 3 both require the use of glGenQueries().
>
> Note that BeginQuery doesn't exist in ES 1 or ES 2.
>
> Fixes es3conform's occlusion_query_invalid_beginquery test.
> ---
>  src/mesa/main/queryobj.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
> index 542a68d..a7fa14c 100644
> --- a/src/mesa/main/queryobj.c
> +++ b/src/mesa/main/queryobj.c
> @@ -327,7 +327,7 @@ _mesa_BeginQueryIndexed(GLenum target, GLuint index, GLuint id)
>
>     q = _mesa_lookup_query_object(ctx, id);
>     if (!q) {
> -      if (ctx->API == API_OPENGL_CORE) {
> +      if (ctx->API != API_OPENGL) {
>           _mesa_error(ctx, GL_INVALID_OPERATION,
>                       "glBeginQuery{Indexed}(non-gen name)");
>           return;
> --
> 1.8.0

Tested-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list