[Mesa-dev] dispatch changes on gles3 branch - Re: [PATCH v3 0/7] Delay exec table initialization until version is computed

Jordan Justen jljusten at gmail.com
Tue Nov 20 10:43:43 PST 2012


On Mon, Nov 19, 2012 at 8:14 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 11/19/2012 05:01 PM, Jordan Justen wrote:
>>
>> GLES3 support requires that the version be computed before the
>> exec table is initialized.
>>
>> For main exec table initialization (api_exec.c):
>> * Rename _mesa_create_exec_table to _mesa_initialize_exec_table
>> * _mesa_initialize_context allocates the exec table, and sets
>>    entries to nop, but leaves functions otherwise uninitialized
>> * Drivers must now call _mesa_compute_version and then
>>    _mesa_initialize_exec_table
>>
>> Similarly for VBO:
>> * _vbo_CreateContext no longer initializes VBO vtxfmt functions
>> * _mesa_initialize_vbo_vtxfmt was added, and drivers must now
>>    call this function after computing the version
>>
>> v3:
>>   * VBO vtxfmt function programming must also be delayed until
>>     the version in computed.
>>   * Combined all driver changes into a single patch
>
>
> Looks okay, though I've never quite understood how the vtxfmt stuff gets set
> up.
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks for looking it over Ken.

I added v3 of the series to the mesa gles3 branch.

-Jordan


More information about the mesa-dev mailing list