[Mesa-dev] [PATCH] i915: Fix wrong sizeof argument in i915_update_tex_unit.

[Matt Turner]

On Wed, Nov 21, 2012 at 12:02 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/20/2012 09:51 PM, Vinson Lee wrote:
>>
>> The bug was found by Coverity.
>>
>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>
>
> Heh... since sizeof(state) and sizeof(*state) are the same on 32-bit
> platforms, this only could have cause problems for a small subset of users.
> This is probably part of the reason it was never noticed. :) It's pretty
> shocking that this line of code has existed since the driver first landed in
> 2006!

And the bad part is that Chad noticed and fixed this in
/i830/_update_tex_unit (735070c45b403a9631415b09e9fd519f601f0229) back
in July but not this one. :)