[Mesa-dev] [PATCH V3 4/7] i965: set attribute w/a bits for packed formats

[Chris Forbes]

Flag the need for various workarounds to be applied by
the vertex shader.

Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
---
 src/mesa/drivers/dri/i965/brw_vs.c | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vs.c b/src/mesa/drivers/dri/i965/brw_vs.c
index 0d2292f..10a3a2e 100644
--- a/src/mesa/drivers/dri/i965/brw_vs.c
+++ b/src/mesa/drivers/dri/i965/brw_vs.c
@@ -446,10 +446,36 @@ static void brw_upload_vs_prog(struct brw_context *brw)
 
    /* BRW_NEW_VERTICES */
    for (i = 0; i < VERT_ATTRIB_MAX; i++) {
-      /* TODO: flag w/a for packed vertex formats here too */
-      if (vp->program.Base.InputsRead & BITFIELD64_BIT(i) &&
-	  brw->vb.inputs[i].glarray->Type == GL_FIXED) {
-	 key.gl_attrib_wa_flags[i] = brw->vb.inputs[i].glarray->Size;
+      if (vp->program.Base.InputsRead & BITFIELD64_BIT(i)) {
+         uint8_t wa_flags = 0;
+
+         switch (brw->vb.inputs[i].glarray->Type) {
+
+         case GL_FIXED:
+            wa_flags = brw->vb.inputs[i].glarray->Size;
+            break;
+
+         case GL_INT_2_10_10_10_REV:
+            wa_flags |= BRW_ATTRIB_WA_SIGN;
+            /* fallthough */
+
+         case GL_UNSIGNED_INT_2_10_10_10_REV:
+            if (brw->vb.inputs[i].glarray->Format == GL_BGRA)
+               wa_flags |= BRW_ATTRIB_WA_BGRA;
+
+            if (brw->vb.inputs[i].glarray->Normalized) {
+               /* TODO: if need to use ES3 rules, and signed, then
+                * set BRW_ATTRIB_WA_NORMALIZE_ES3 instead */
+
+               wa_flags |= BRW_ATTRIB_WA_NORMALIZE;
+            }
+            else if (!brw->vb.inputs[i].glarray->Integer)
+               wa_flags |= BRW_ATTRIB_WA_SCALE;
+
+            break;
+         }
+
+         key.gl_attrib_wa_flags[i] = wa_flags;
       }
    }
 
-- 
1.8.0