[Mesa-dev] [PATCH 6/8] i965/vs: Abort on unsupported opcodes rather than failing.
Kenneth Graunke
kenneth at whitecape.org
Tue Nov 27 00:42:31 PST 2012
Final code generation should never fail. This is a bug, and there
should be no user-triggerable cases where this could occur.
Also, we're not going to have a fail() method after the split.
---
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index b911983..a2a5975 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
@@ -641,11 +641,12 @@ vec4_visitor::generate_vs_instruction(vec4_instruction *instruction,
default:
if (inst->opcode < (int) ARRAY_SIZE(opcode_descs)) {
- fail("unsupported opcode in `%s' in VS\n",
- opcode_descs[inst->opcode].name);
+ _mesa_problem(ctx, "Unsupported opcode in `%s' in VS\n",
+ opcode_descs[inst->opcode].name);
} else {
- fail("Unsupported opcode %d in VS", inst->opcode);
+ _mesa_problem(ctx, "Unsupported opcode %d in VS", inst->opcode);
}
+ abort();
}
}
--
1.8.0
More information about the mesa-dev
mailing list